Skip to content

Remove fromcanonical in points for BivariateSpace #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Sep 20, 2023

Fix #602

After this,

julia> S = Chebyshev(1..2)Chebyshev(3..4)
Chebyshev(1 .. 2)  Chebyshev(3 .. 4)

julia> [p  domain(factor(S, 1)) for p in points(S, 10, 10)[1]]
10×10 Matrix{Bool}:
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1

julia> [p  domain(factor(S, 2)) for p in points(S, 10, 10)[2]]
10×10 Matrix{Bool}:
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1
 1  1  1  1  1  1  1  1  1  1

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 81.57% and project coverage change: +0.04% 🎉

Comparison is base (28eb4ea) 75.24% compared to head (e042253) 75.28%.
Report is 3 commits behind head on master.

❗ Current head e042253 differs from pull request most recent head ea4668f. Consider uploading reports for the commit ea4668f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #603      +/-   ##
==========================================
+ Coverage   75.24%   75.28%   +0.04%     
==========================================
  Files          80       80              
  Lines        8421     8435      +14     
==========================================
+ Hits         6336     6350      +14     
  Misses       2085     2085              
Files Changed Coverage Δ
src/Fun.jl 69.15% <0.00%> (+0.33%) ⬆️
src/Spaces/SubSpace.jl 66.32% <60.00%> (ø)
src/Spaces/ConstantSpace.jl 59.34% <77.77%> (+2.08%) ⬆️
src/Multivariate/TensorSpace.jl 87.50% <91.66%> (+0.17%) ⬆️
src/Multivariate/TrivialTensorFun.jl 96.00% <100.00%> (ø)
src/Operators/SubOperator.jl 84.31% <100.00%> (ø)
src/Operators/general/FiniteOperator.jl 50.00% <100.00%> (+5.17%) ⬆️
src/Operators/general/InterlaceOperator.jl 84.71% <100.00%> (ø)
src/constructors.jl 80.95% <100.00%> (ø)
src/show.jl 97.22% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit 9c921b3 into JuliaApproximation:master Sep 21, 2023
@jishnub jishnub deleted the bivariatepoints branch September 21, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Are ProductFun points broken?
1 participant