Skip to content

Remove barysum #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Remove barysum #102

merged 1 commit into from
Sep 9, 2022

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Sep 9, 2022

Remove barysum, which is exported but undefined.

The compat limit on ApproxFunBase is keeping in mind the removal of the exported but undefined symbol jumplocations from it. Currently,

julia> @which jumplocations
ApproxFunOrthogonalPolynomials

so the export from ApproxFunBase is not having any impact. This will be removed in ApproxFunBase v0.6.22, which is technically not a breaking change, as the exported symbol isn't defined.

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Base: 58.87% // Head: 58.87% // No change to project coverage 👍

Coverage data is based on head (2adfc79) compared to base (d082f07).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   58.87%   58.87%           
=======================================
  Files          28       28           
  Lines        2461     2461           
=======================================
  Hits         1449     1449           
  Misses       1012     1012           
Impacted Files Coverage Δ
src/bary.jl 0.00% <ø> (ø)
src/specialfunctions.jl 66.66% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit cbfb1b9 into JuliaApproximation:master Sep 9, 2022
@jishnub jishnub deleted the nobarysum branch September 9, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant