Skip to content

lower bandwidth for Derivative(::Hermite) #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Sep 14, 2022

On master

julia> Derivative(Hermite())
ConcreteDerivative : Hermite{Float64}(1.0)  Hermite{Float64}(1.0)
 0.0  2.0                                       
     0.0  4.0                                   
         0.0  6.0                               
             0.0  8.0                           
                 0.0  10.0                      
                      0.0  12.0                 
                           0.0  14.0            
                                0.0  16.0       
                                     0.0  18.0  
                                          0.0  
                                              

This PR

julia> Derivative(Hermite())
ConcreteDerivative : Hermite{Float64}(1.0)  Hermite{Float64}(1.0)
   2.0                                       
       4.0                                   
           6.0                               
               8.0                           
                   10.0                      
                        12.0                 
                             14.0            
                                  16.0       
                                       18.0  
                                            
                                            

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 58.91% // Head: 67.38% // Increases project coverage by +8.46% 🎉

Coverage data is based on head (803b079) compared to base (c52133b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   58.91%   67.38%   +8.46%     
==========================================
  Files          28       28              
  Lines        2461     2462       +1     
==========================================
+ Hits         1450     1659     +209     
+ Misses       1011      803     -208     
Impacted Files Coverage Δ
src/Spaces/Hermite/Hermite.jl 71.42% <100.00%> (+22.07%) ⬆️
src/Spaces/PolynomialSpace.jl 86.95% <0.00%> (+0.43%) ⬆️
src/Spaces/Laguerre/Laguerre.jl 59.02% <0.00%> (+1.38%) ⬆️
src/Spaces/Jacobi/Jacobi.jl 62.37% <0.00%> (+1.98%) ⬆️
src/Spaces/Ultraspherical/Ultraspherical.jl 83.33% <0.00%> (+2.08%) ⬆️
src/Spaces/Ultraspherical/ContinuousSpace.jl 54.28% <0.00%> (+3.03%) ⬆️
src/show.jl 55.88% <0.00%> (+8.82%) ⬆️
src/Spaces/Ultraspherical/DirichletSpace.jl 38.67% <0.00%> (+9.43%) ⬆️
src/Spaces/Jacobi/JacobiOperators.jl 71.52% <0.00%> (+11.97%) ⬆️
src/Domains/Arc.jl 63.41% <0.00%> (+12.19%) ⬆️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit 9edabe1 into JuliaApproximation:master Sep 14, 2022
@jishnub jishnub deleted the HermiteDerivbw branch September 14, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant