Skip to content

Drop support for Julia versions <v1.6 #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 15, 2022
Merged

Drop support for Julia versions <v1.6 #127

merged 4 commits into from
Oct 15, 2022

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Oct 15, 2022

No description provided.

@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Base: 53.51% // Head: 67.51% // Increases project coverage by +13.99% 🎉

Coverage data is based on head (a2a6121) compared to base (f919bc3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #127       +/-   ##
===========================================
+ Coverage   53.51%   67.51%   +13.99%     
===========================================
  Files          28       28               
  Lines        2474     2475        +1     
===========================================
+ Hits         1324     1671      +347     
+ Misses       1150      804      -346     
Impacted Files Coverage Δ
src/Domains/Line.jl 42.34% <0.00%> (+0.90%) ⬆️
src/Domains/Arc.jl 63.41% <0.00%> (+2.43%) ⬆️
src/show.jl 55.88% <0.00%> (+2.94%) ⬆️
src/Spaces/Ultraspherical/DirichletSpace.jl 38.67% <0.00%> (+3.77%) ⬆️
src/Spaces/Ultraspherical/ContinuousSpace.jl 54.28% <0.00%> (+5.00%) ⬆️
src/roots.jl 73.91% <0.00%> (+5.21%) ⬆️
src/Spaces/Chebyshev/Chebyshev.jl 76.08% <0.00%> (+6.52%) ⬆️
src/Domains/Ray.jl 77.19% <0.00%> (+7.01%) ⬆️
src/Spaces/Jacobi/JacobiOperators.jl 71.52% <0.00%> (+9.38%) ⬆️
src/Spaces/Chebyshev/ChebyshevOperators.jl 93.89% <0.00%> (+9.92%) ⬆️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub
Copy link
Member Author

jishnub commented Oct 15, 2022

Huh, test failure seems to be due to a Julia precision bug on Windows on version v1.6. A workaround may be to reduce the tested precision on v1.6.

@jishnub jishnub merged commit bf205b4 into master Oct 15, 2022
@jishnub jishnub deleted the jishnub-patch-3 branch October 15, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant