Skip to content

Add type parameter to Jacobi #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 10, 2022
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Dec 5, 2022

Using integer orders makes comparisons with integers easier, e.g. n + 0.5 is statically known to not be an integer if n is an integer.

On master

julia> @inferred ApproxFunBase.maxspace(Jacobi(1,1), Jacobi(2,2))
ERROR: return type Jacobi{ChebyshevInterval{Float64}, Float64} does not match inferred return type Any
Stacktrace:
 [1] error(s::String)
   @ Base ./error.jl:35
 [2] top-level scope
   @ REPL[5]:1

After this PR, this is fully type-inferred.

julia> @inferred ApproxFunBase.maxspace(Jacobi(1,1), Jacobi(2,2))
Jacobi(2,2)

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 60.58% // Head: 61.04% // Increases project coverage by +0.46% 🎉

Coverage data is based on head (1175fda) compared to base (0b7ecbb).
Patch coverage: 90.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   60.58%   61.04%   +0.46%     
==========================================
  Files          28       28              
  Lines        2471     2490      +19     
==========================================
+ Hits         1497     1520      +23     
+ Misses        974      970       -4     
Impacted Files Coverage Δ
src/Domains/Ray.jl 58.46% <75.00%> (+14.60%) ⬆️
src/Spaces/Jacobi/Jacobi.jl 63.10% <85.71%> (+0.73%) ⬆️
...c/Spaces/Ultraspherical/UltrasphericalOperators.jl 79.67% <87.50%> (-0.11%) ⬇️
src/Spaces/IntervalSpace.jl 75.00% <100.00%> (+8.33%) ⬆️
src/Spaces/Jacobi/JacobiOperators.jl 67.04% <100.00%> (+0.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit 1f64473 into JuliaApproximation:master Dec 10, 2022
@jishnub jishnub deleted the jacobiparam branch December 10, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant