Skip to content

Skip jumplocations test for sign sum #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Dec 7, 2022

This test fails intermittently, and I'm not being able to replicate the error locally. I'm disabling this for now while I look into it

@jishnub jishnub changed the title skip jumplocations test on mac Skip jumplocations test for sign sum Dec 7, 2022
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 60.58% // Head: 66.80% // Increases project coverage by +6.21% 🎉

Coverage data is based on head (a91a2a2) compared to base (3ed8ffe).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   60.58%   66.80%   +6.21%     
==========================================
  Files          28       28              
  Lines        2466     2467       +1     
==========================================
+ Hits         1494     1648     +154     
+ Misses        972      819     -153     
Impacted Files Coverage Δ
src/Spaces/PolynomialSpace.jl 88.80% <0.00%> (+0.39%) ⬆️
src/Spaces/Laguerre/Laguerre.jl 60.13% <0.00%> (+1.35%) ⬆️
src/Spaces/Chebyshev/Chebyshev.jl 59.42% <0.00%> (+1.44%) ⬆️
src/Spaces/Ultraspherical/Ultraspherical.jl 76.36% <0.00%> (+1.81%) ⬆️
src/Spaces/Jacobi/Jacobi.jl 64.35% <0.00%> (+1.98%) ⬆️
src/Spaces/Ultraspherical/ContinuousSpace.jl 54.28% <0.00%> (+3.03%) ⬆️
src/show.jl 55.88% <0.00%> (+8.82%) ⬆️
src/Spaces/Ultraspherical/DirichletSpace.jl 50.00% <0.00%> (+9.80%) ⬆️
src/Spaces/Jacobi/JacobiOperators.jl 77.69% <0.00%> (+11.15%) ⬆️
src/Domains/Arc.jl 63.41% <0.00%> (+12.19%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit 48c7954 into JuliaApproximation:master Dec 7, 2022
@jishnub jishnub deleted the skipjumploc branch December 27, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant