Skip to content

hasconversion for tensorspace #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jan 9, 2023

After this, the following works:

julia> ApproxFunBase.hasconversion(Chebyshev()*Legendre(), Chebyshev()*NormalizedLegendre())
true

On master

julia> f = Fun((x,y)->x^10*y^4 + x^2*y^3, Chebyshev()*Legendre());

TTFX

julia> @time Fun(f, Chebyshev()*NormalizedLegendre());
 12.396606 seconds (41.16 M allocations: 2.226 GiB, 6.72% gc time, 99.99% compilation time)

Benchmark

julia> @btime Fun($f, Chebyshev()*NormalizedLegendre());
  287.812 μs (416 allocations: 66.70 KiB)

This PR
TTFX

julia> @time Fun(f, Chebyshev()*NormalizedLegendre());
 10.915021 seconds (38.30 M allocations: 2.089 GiB, 6.96% gc time, 99.99% compilation time)

Benchmark

julia> @btime Fun($f, Chebyshev()*NormalizedLegendre());
  66.401 μs (1386 allocations: 113.58 KiB)

The allocations go up, but the execution time is lower.

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Base: 61.05% // Head: 67.38% // Increases project coverage by +6.33% 🎉

Coverage data is based on head (c60b2b2) compared to base (864d832).
Patch coverage: 83.67% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   61.05%   67.38%   +6.33%     
==========================================
  Files          28       28              
  Lines        2488     2493       +5     
==========================================
+ Hits         1519     1680     +161     
+ Misses        969      813     -156     
Impacted Files Coverage Δ
src/ApproxFunOrthogonalPolynomials.jl 66.66% <ø> (ø)
src/Spaces/Chebyshev/Chebyshev.jl 59.57% <ø> (+1.41%) ⬆️
src/Spaces/Hermite/Hermite.jl 70.51% <ø> (+21.79%) ⬆️
src/Spaces/Laguerre/Laguerre.jl 60.13% <ø> (+1.35%) ⬆️
src/Spaces/Jacobi/Jacobi.jl 65.04% <66.66%> (+1.94%) ⬆️
src/Spaces/Jacobi/JacobiOperators.jl 80.68% <81.48%> (+13.26%) ⬆️
src/Spaces/PolynomialSpace.jl 89.10% <91.66%> (+0.70%) ⬆️
src/Spaces/Ultraspherical/Ultraspherical.jl 79.31% <100.00%> (+1.72%) ⬆️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit 26f8f70 into JuliaApproximation:master Jan 9, 2023
@jishnub jishnub deleted the normalizedconversion branch January 9, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant