Skip to content

supportsinplacetransform for float-domain Chebyshev #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Feb 16, 2023

On master

julia> @btime Fun(x -> x^20, Chebyshev());
  107.806 μs (218 allocations: 19.08 KiB)

This PR

julia> @btime Fun(x -> x^20, Chebyshev());
  33.232 μs (118 allocations: 8.50 KiB)

The improvement comes from allocating fewer arrays, and carrying out transforms in-place.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 60.95% // Head: 67.15% // Increases project coverage by +6.20% 🎉

Coverage data is based on head (fd5d473) compared to base (a94565e).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   60.95%   67.15%   +6.20%     
==========================================
  Files          28       28              
  Lines        2492     2509      +17     
==========================================
+ Hits         1519     1685     +166     
+ Misses        973      824     -149     
Impacted Files Coverage Δ
src/ApproxFunOrthogonalPolynomials.jl 66.66% <ø> (ø)
...c/Spaces/Ultraspherical/UltrasphericalOperators.jl 75.40% <40.00%> (-0.98%) ⬇️
src/Spaces/Chebyshev/Chebyshev.jl 59.85% <100.00%> (+1.70%) ⬆️
src/Spaces/Chebyshev/ChebyshevOperators.jl 86.33% <100.00%> (+0.09%) ⬆️
src/Spaces/Hermite/Hermite.jl 70.88% <100.00%> (+22.16%) ⬆️
src/Spaces/Jacobi/JacobiOperators.jl 80.14% <100.00%> (+12.34%) ⬆️
src/Spaces/PolynomialSpace.jl 89.31% <100.00%> (+0.59%) ⬆️
src/Spaces/Ultraspherical/ContinuousSpace.jl 54.28% <100.00%> (+3.03%) ⬆️
src/Spaces/Laguerre/Laguerre.jl 60.13% <0.00%> (+1.35%) ⬆️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit 04da653 into JuliaApproximation:master Feb 16, 2023
@jishnub jishnub deleted the supportsinplacetransform branch March 10, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant