Skip to content

simplify jacobi conversion #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2023
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Feb 18, 2023

After this, Conversion(Jacobi(1,1), Jacobi(2,2)) is inferred as a small union of concretely inferred types.

@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Base: 60.95% // Head: 67.07% // Increases project coverage by +6.12% 🎉

Coverage data is based on head (9b88e48) compared to base (a94565e).
Patch coverage: 73.68% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   60.95%   67.07%   +6.12%     
==========================================
  Files          28       28              
  Lines        2492     2518      +26     
==========================================
+ Hits         1519     1689     +170     
+ Misses        973      829     -144     
Impacted Files Coverage Δ
src/ApproxFunOrthogonalPolynomials.jl 66.66% <ø> (ø)
...c/Spaces/Ultraspherical/UltrasphericalOperators.jl 73.60% <62.22%> (-2.77%) ⬇️
src/Spaces/Jacobi/Jacobi.jl 65.04% <75.00%> (+1.94%) ⬆️
src/Spaces/PolynomialSpace.jl 89.31% <85.71%> (+0.59%) ⬆️
src/Spaces/Jacobi/JacobiOperators.jl 80.00% <90.00%> (+12.19%) ⬆️
src/Spaces/Chebyshev/Chebyshev.jl 59.85% <100.00%> (+1.70%) ⬆️
src/Spaces/Chebyshev/ChebyshevOperators.jl 86.33% <100.00%> (+0.09%) ⬆️
src/Spaces/Hermite/Hermite.jl 70.88% <100.00%> (+22.16%) ⬆️
src/Spaces/Ultraspherical/ContinuousSpace.jl 54.28% <100.00%> (+3.03%) ⬆️
src/Spaces/Ultraspherical/Ultraspherical.jl 81.48% <100.00%> (+3.89%) ⬆️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit 26de0e1 into JuliaApproximation:master Feb 18, 2023
@jishnub jishnub deleted the jacobiconvert branch February 18, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant