Skip to content

Assert domain compatibility in conversions #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Assert domain compatibility in conversions #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Spaces/Jacobi/JacobiOperators.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,12 +227,14 @@ end
# Assume m is compatible

function Conversion(A::PolynomialSpace,B::Jacobi)
@assert domain(A) == domain(B)
J = Jacobi(A)
J == B ? ConcreteConversion(A,B) :
ConversionWrapper(TimesOperator(Conversion(J,B),Conversion(A,J)))
end

function Conversion(A::Jacobi,B::PolynomialSpace)
@assert domain(A) == domain(B)
J = Jacobi(B)
J == A ? ConcreteConversion(A,B) :
ConversionWrapper(TimesOperator(Conversion(J,B),Conversion(A,J)))
Expand All @@ -242,6 +244,7 @@ isequalminhalf(x) = x == -0.5
isequalminhalf(@nospecialize ::Integer) = false

function Conversion(A::Jacobi,B::Chebyshev)
@assert domain(A) == domain(B)
if isequalminhalf(A.a) && isequalminhalf(A.b)
ConcreteConversion(A,B)
elseif A.a == A.b == 0
Expand All @@ -259,6 +262,7 @@ function Conversion(A::Jacobi,B::Chebyshev)
end

function Conversion(A::Chebyshev,B::Jacobi)
@assert domain(A) == domain(B)
if isequalminhalf(B.a) && isequalminhalf(B.b)
ConcreteConversion(A,B)
elseif B.a == B.b == 0
Expand All @@ -277,6 +281,7 @@ end


function Conversion(A::Jacobi,B::Ultraspherical)
@assert domain(A) == domain(B)
if isequalminhalf(A.a) && isequalminhalf(A.b)
ConversionWrapper(Conversion(Chebyshev(domain(A)),B)*
ConcreteConversion(A,Chebyshev(domain(A))))
Expand All @@ -297,6 +302,7 @@ function Conversion(A::Jacobi,B::Ultraspherical)
end

function Conversion(A::Ultraspherical,B::Jacobi)
@assert domain(A) == domain(B)
if isequalminhalf(B.a) && isequalminhalf(B.b)
ConversionWrapper(ConcreteConversion(Chebyshev(domain(A)),B)*
Conversion(A,Chebyshev(domain(A))))
Expand Down
6 changes: 3 additions & 3 deletions src/Spaces/Ultraspherical/UltrasphericalOperators.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,10 @@ isequalhalf(x) = x == 0.5
isequalhalf(::Integer) = false

function Conversion(A::Chebyshev, B::Ultraspherical)
@assert domain(A) == domain(B)
mB = order(B)
d=domain(A)
dB = domain(B)
d == dB || throw(ArgumentError("domains must be identical"))
if isequalhalf(mB) || mB == 1
return ConcreteConversion(A,B)
elseif (isinteger(mB) || isapproxinteger_addhalf(mB)) && mB > 0
Expand All @@ -147,6 +147,7 @@ function Conversion(A::Chebyshev, B::Ultraspherical)
end

function Conversion(A::Ultraspherical,B::Chebyshev)
@assert domain(A) == domain(B)
if isequalhalf(order(A)) && domain(A) == domain(B)
return ConcreteConversion(A,B)
end
Expand All @@ -158,10 +159,9 @@ maxspace_rule(A::Ultraspherical,B::Chebyshev) = A


function Conversion(A::Ultraspherical,B::Ultraspherical)
@assert domain(A) == domain(B)
a=order(A); b=order(B)
d=domain(A)
dB = domain(B)
d == dB || throw(ArgumentError("domains must be identical"))
if b==a
return ConversionWrapper(Operator(I,A))
elseif isapproxinteger(b-a) || isapproxinteger_addhalf(b-a)
Expand Down