Skip to content

Inference in normalized space multiplication #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Inference in normalized space multiplication #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Spaces/Jacobi/JacobiOperators.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ function Conversion(L::Jacobi,M::Jacobi)
end
end

throw(ArgumentError("please implement $A → $B"))
throw(ArgumentError("please implement $L → $M"))
end

bandwidths(::ConcreteConversion{<:Jacobi,<:Jacobi}) = (0,1)
Expand Down
13 changes: 6 additions & 7 deletions src/Spaces/PolynomialSpace.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,17 +486,16 @@ end

function Multiplication(f::Fun{<:PolynomialSpace}, sp::NormalizedPolynomialSpace)
unnorm_sp = canonicalspace(sp)
O = Conversion(unnorm_sp,sp) *
Multiplication(f,unnorm_sp) * Conversion(sp, unnorm_sp)
O = ConcreteConversion(unnorm_sp,sp) *
Multiplication(f,unnorm_sp) * ConcreteConversion(sp, unnorm_sp)
MultiplicationWrapper(f, O, sp)
end

function Multiplication(f::Fun{ <: NormalizedPolynomialSpace}, sp::PolynomialSpace)
Multiplication(Conversion(space(f), canonicalspace(f))*f, sp)
function Multiplication(f::Fun{<:NormalizedPolynomialSpace}, sp::PolynomialSpace)
Multiplication(ConcreteConversion(space(f), canonicalspace(f))*f, sp)
end

function Multiplication(f::Fun{U},sp::NormalizedPolynomialSpace) where U <: NormalizedPolynomialSpace
csp = canonicalspace(f)
fc = Conversion(space(f), csp)*f
function Multiplication(f::Fun{<:NormalizedPolynomialSpace}, sp::NormalizedPolynomialSpace)
fc = ConcreteConversion(space(f), canonicalspace(f))*f
Multiplication(fc, sp)
end
7 changes: 7 additions & 0 deletions test/JacobiTest.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,13 @@ using Static
M = @inferred Multiplication(Fun(L), NormalizedPolynomialSpace(L))
@test M * Fun(NormalizedLegendre()) ≈ Fun(x->x^2, NormalizedLegendre())
end

M1 = @inferred Multiplication(Fun(Legendre()), NormalizedLegendre())
@test M1 * Fun(x->x^4, NormalizedLegendre()) ≈ Fun(x->x^5, NormalizedLegendre())
M2 = @inferred Multiplication(Fun(NormalizedLegendre()), Legendre())
@test M2 * Fun(x->x^4, Legendre()) ≈ Fun(x->x^5, Legendre())
M3 = @inferred Multiplication(Fun(NormalizedLegendre()), NormalizedLegendre())
@test M3 * Fun(x->x^4, NormalizedLegendre()) ≈ Fun(x->x^5, NormalizedLegendre())
end

@testset "Jacobi integrate and sum" begin
Expand Down