Reduce allocations in jac_gbmm #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 61.78% // Head: 68.14% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #196 +/- ##
==========================================
+ Coverage 61.78% 68.14% +6.35%
==========================================
Files 28 28
Lines 2546 2574 +28
==========================================
+ Hits 1573 1754 +181
+ Misses 973 820 -153
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use loops instead of broadcasting over views, as the views of views often allocate vectors of indices.
Also, call the GC after each testset to avoid excessive memory usage during tests.