Skip to content

Don't dispatch on leftendpoint/rightendpoint in Evaluation #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Apr 21, 2023

After this,

julia> bvp(Chebyshev())
2-element Vector{ApproxFunBase.ConcreteEvaluation{Chebyshev{ChebyshevInterval{Float64}, Float64}, ApproxFunBase.Boundary, Int64, Float64}}:
 ConcreteEvaluation : Chebyshev()  ConstantSpace(Point(-1.0))
 ConcreteEvaluation : Chebyshev()  ConstantSpace(Point(1.0))

where the eltype is concrete.

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 86.04% and project coverage change: +0.54 🎉

Comparison is base (69c583a) 69.14% compared to head (bd9b9a2) 69.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
+ Coverage   69.14%   69.68%   +0.54%     
==========================================
  Files          28       28              
  Lines        2573     2619      +46     
==========================================
+ Hits         1779     1825      +46     
  Misses        794      794              
Impacted Files Coverage Δ
src/ApproxFunOrthogonalPolynomials.jl 81.48% <ø> (ø)
src/Spaces/Jacobi/jacobitransform.jl 100.00% <ø> (ø)
src/Spaces/Ultraspherical/DirichletSpace.jl 50.45% <37.93%> (+0.45%) ⬆️
src/Spaces/Chebyshev/Chebyshev.jl 59.85% <100.00%> (ø)
src/Spaces/Chebyshev/ChebyshevOperators.jl 87.14% <100.00%> (+0.28%) ⬆️
src/Spaces/Jacobi/Jacobi.jl 66.66% <100.00%> (+0.32%) ⬆️
src/Spaces/Jacobi/JacobiOperators.jl 83.50% <100.00%> (-0.18%) ⬇️
src/Spaces/PolynomialSpace.jl 92.76% <100.00%> (+0.81%) ⬆️
src/Spaces/Spaces.jl 100.00% <100.00%> (ø)
src/Spaces/Ultraspherical/Ultraspherical.jl 93.10% <100.00%> (+2.03%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit 5e9c350 into JuliaApproximation:master Apr 21, 2023
@jishnub jishnub deleted the evaluation branch April 21, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant