Skip to content

Faster indexing for Ultraspherical(0.5)Legendre #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jun 9, 2023

After this,

julia> C = Conversion(Ultraspherical(0.5), Legendre());

julia> @btime $C[1:100, 1:100];
  169.329 ns (2 allocations: 944 bytes) # PR
  821.360 ns (6 allocations: 4.42 KiB) # master

This also fixes

julia> Conversion(NormalizedUltraspherical(1.5), NormalizedJacobi(1,1))
ConversionWrapper : NormalizedUltraspherical(1.5)  NormalizedJacobi(1,1)
 1.0000000000000002                                              
                    1.0000000000000002                            
                                                                 
                                                                 
                                                                 
                                                                
                                                                 
                                                                 
                                          1.0000000000000004      
                                                             1.0  
                                                                

@jishnub jishnub changed the title Faster indexing for Ultraspherical(0.5)<->Legendre Faster indexing for Ultraspherical(0.5)Legendre Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 98.03% and project coverage change: +0.58 🎉

Comparison is base (271f812) 69.70% compared to head (c327d47) 70.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   69.70%   70.28%   +0.58%     
==========================================
  Files          28       28              
  Lines        2667     2679      +12     
==========================================
+ Hits         1859     1883      +24     
+ Misses        808      796      -12     
Impacted Files Coverage Δ
src/Spaces/Jacobi/JacobiOperators.jl 85.11% <96.96%> (+4.77%) ⬆️
src/ApproxFunOrthogonalPolynomials.jl 90.00% <100.00%> (ø)
src/Spaces/Jacobi/Jacobi.jl 68.14% <100.00%> (ø)
src/Spaces/PolynomialSpace.jl 93.16% <100.00%> (-0.05%) ⬇️
...c/Spaces/Ultraspherical/UltrasphericalOperators.jl 80.18% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit 2721a0d into JuliaApproximation:master Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant