Skip to content

Faster evaluation in normalized spaces #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jun 21, 2023

This was hitting the fallback method previously, which was slow.
On master

julia> E = Evaluation(NormalizedUltraspherical(1), 0.5);

julia> @btime $E[1,1];
  2.391 μs (23 allocations: 704 bytes)

This PR

julia> @btime $E[1,1];
  183.369 ns (2 allocations: 128 bytes)

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 92.85% and project coverage change: +0.88 🎉

Comparison is base (441f970) 70.36% compared to head (db4cad5) 71.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   70.36%   71.24%   +0.88%     
==========================================
  Files          28       28              
  Lines        2686     2699      +13     
==========================================
+ Hits         1890     1923      +33     
+ Misses        796      776      -20     
Impacted Files Coverage Δ
src/Spaces/Ultraspherical/DirichletSpace.jl 48.64% <0.00%> (ø)
src/Spaces/CurveSpace.jl 25.58% <100.00%> (+25.58%) ⬆️
src/Spaces/PolynomialSpace.jl 93.39% <100.00%> (+0.22%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit 18f7083 into JuliaApproximation:master Jun 21, 2023
@jishnub jishnub deleted the normevaluation branch June 21, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant