Skip to content

Slightly reduce allocations in Chebyshev Fun integrate #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jul 23, 2023

On master

julia> f = Fun();

julia> @btime integrate($f)
  108.817 ns (3 allocations: 240 bytes)
Fun(Chebyshev(), [0.0, 0.0, 0.25])

This PR

julia> @btime integrate($f)
  73.764 ns (2 allocations: 160 bytes)
Fun(Chebyshev(), [0.0, 0.0, 0.25])

@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Patch coverage: 91.42% and project coverage change: +22.70 🎉

Comparison is base (75383fe) 49.48% compared to head (c50f0e8) 72.18%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #279       +/-   ##
===========================================
+ Coverage   49.48%   72.18%   +22.70%     
===========================================
  Files          28       29        +1     
  Lines        2696     2736       +40     
===========================================
+ Hits         1334     1975      +641     
+ Misses       1362      761      -601     
Impacted Files Coverage Δ
src/ApproxFunOrthogonalPolynomials.jl 87.80% <ø> (+28.62%) ⬆️
src/ultraspherical.jl 61.84% <73.33%> (+11.84%) ⬆️
...c/Spaces/Ultraspherical/UltrasphericalOperators.jl 83.33% <87.50%> (+43.24%) ⬆️
src/Spaces/Chebyshev/Chebyshev.jl 62.89% <91.66%> (+12.18%) ⬆️
ext/ApproxFunOrthogonalPolynomialsStaticExt.jl 95.55% <95.55%> (ø)
src/Spaces/PolynomialSpace.jl 93.41% <100.00%> (+25.34%) ⬆️
src/Spaces/Spaces.jl 100.00% <100.00%> (+31.50%) ⬆️
src/Spaces/Ultraspherical/Ultraspherical.jl 86.00% <100.00%> (+60.13%) ⬆️
src/fastops.jl 100.00% <100.00%> (ø)
src/show.jl 57.89% <100.00%> (+7.89%) ⬆️

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit b4c84f0 into JuliaApproximation:master Jul 23, 2023
@jishnub jishnub deleted the chebyshevderivint branch July 23, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant