Skip to content

reduce allocations in Chebyshev deriv #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jul 24, 2023

On master

julia> f = Fun(x->x^4, Chebyshev());

julia> @btime $f';
  113.291 ns (3 allocations: 288 bytes)

This PR

julia> @btime $f';
  55.667 ns (1 allocation: 96 bytes)

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 91.26% and project coverage change: +22.65 🎉

Comparison is base (75383fe) 49.48% compared to head (96e1fe3) 72.13%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #280       +/-   ##
===========================================
+ Coverage   49.48%   72.13%   +22.65%     
===========================================
  Files          28       29        +1     
  Lines        2696     2738       +42     
===========================================
+ Hits         1334     1975      +641     
+ Misses       1362      763      -599     
Impacted Files Coverage Δ
src/ApproxFunOrthogonalPolynomials.jl 87.80% <ø> (+28.62%) ⬆️
src/ultraspherical.jl 59.74% <82.85%> (+9.74%) ⬆️
...c/Spaces/Ultraspherical/UltrasphericalOperators.jl 83.33% <87.50%> (+43.24%) ⬆️
src/Spaces/Chebyshev/Chebyshev.jl 63.12% <92.00%> (+12.42%) ⬆️
ext/ApproxFunOrthogonalPolynomialsStaticExt.jl 95.55% <95.55%> (ø)
src/Spaces/PolynomialSpace.jl 93.41% <100.00%> (+25.34%) ⬆️
src/Spaces/Spaces.jl 100.00% <100.00%> (+31.50%) ⬆️
src/Spaces/Ultraspherical/Ultraspherical.jl 86.00% <100.00%> (+60.13%) ⬆️
src/fastops.jl 100.00% <100.00%> (ø)
src/show.jl 57.89% <100.00%> (+7.89%) ⬆️

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit 3e4075c into JuliaApproximation:master Jul 24, 2023
@jishnub jishnub deleted the chebyderiv branch July 24, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant