Skip to content

Ultraspherical conversion error catching #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2020

Conversation

Gyoshi
Copy link
Contributor

@Gyoshi Gyoshi commented Mar 29, 2020

Closes #31

@dlfivefifty
Copy link
Member

For some reason Travis checks are not running on any repository... let me look into it

@Gyoshi Gyoshi closed this Apr 8, 2020
@Gyoshi Gyoshi reopened this Apr 8, 2020
@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #32 into master will decrease coverage by 1.70%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   56.83%   55.13%   -1.71%     
==========================================
  Files          27       27              
  Lines        2106     2171      +65     
==========================================
  Hits         1197     1197              
- Misses        909      974      +65     
Impacted Files Coverage Δ
...c/Spaces/Ultraspherical/UltrasphericalOperators.jl 73.64% <100.00%> (-0.51%) ⬇️
src/Spaces/Ultraspherical/DirichletSpace.jl 27.00% <0.00%> (-3.00%) ⬇️
src/ultraspherical.jl 54.92% <0.00%> (-2.43%) ⬇️
src/Spaces/Jacobi/JacobiOperators.jl 49.81% <0.00%> (-2.26%) ⬇️
src/Spaces/PolynomialSpace.jl 80.30% <0.00%> (-2.09%) ⬇️
src/Spaces/Hermite/Hermite.jl 47.94% <0.00%> (-2.06%) ⬇️
src/specialfunctions.jl 68.42% <0.00%> (-1.85%) ⬇️
src/Spaces/Jacobi/Jacobi.jl 49.41% <0.00%> (-1.81%) ⬇️
src/roots.jl 53.00% <0.00%> (-1.64%) ⬇️
src/Domains/Line.jl 23.14% <0.00%> (-1.37%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae6d0f6...52794f4. Read the comment docs.

@dlfivefifty
Copy link
Member

Can you add a test? (Something that fails without it but now passes.)

@Gyoshi
Copy link
Contributor Author

Gyoshi commented Apr 10, 2020

I could add

@test_throws ArgumentError Conversion(Ultraspherical(2), Ultraspherical(1))
@test_throws ArgumentError Conversion(Ultraspherical(3), Ultraspherical(1.9))

but the error for 3 -> 1.9 is only there due to incomplete implementation. If it someone implements it, it shouldn't fail the tests because of that, right?

@dlfivefifty
Copy link
Member

Those tests sound fine. Yes if they are implemented that can be changed

@dlfivefifty dlfivefifty merged commit d95695e into JuliaApproximation:master Apr 17, 2020
@dlfivefifty
Copy link
Member

I think the test failure is unrelated, I'll merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ultraspherical conversion to lower order domain error consistency
2 participants