Skip to content

Concrete operators in normalized spaces #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Feb 4, 2024

In cases where the canonicalspace supports a concrete operator, the corresponding operator in the normalized space may also be concrete, which will avoid type-inference issues with TimesOperator and be much faster overall. E.g., after this,

julia> Derivative(NormalizedChebyshev(), 2)
ConcreteDerivative : NormalizedChebyshev()  Ultraspherical(2)
         3.19154                                                          
                 4.78731                                                  
                         6.38308                                          
                                 7.97885                                  
                                         9.57461                          
                                                 11.1704                  
                                                         12.7662          
                                                                 14.3619  
                                                                         
                                                                         
                                                                         

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (422ec82) 69.41% compared to head (2c50c14) 73.08%.
Report is 4 commits behind head on master.

Files Patch % Lines
src/Spaces/Chebyshev/ChebyshevOperators.jl 90.47% 2 Missing ⚠️
...c/Spaces/Ultraspherical/UltrasphericalOperators.jl 85.71% 1 Missing ⚠️
src/fastops.jl 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   69.41%   73.08%   +3.66%     
==========================================
  Files          30       30              
  Lines        2805     2827      +22     
==========================================
+ Hits         1947     2066     +119     
+ Misses        858      761      -97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub force-pushed the concreteopnormalized branch from 87b4308 to bf25662 Compare February 5, 2024 07:43
@jishnub jishnub merged commit e9b80aa into JuliaApproximation:master Feb 5, 2024
@jishnub jishnub deleted the concreteopnormalized branch February 5, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant