Skip to content

Fixes for DomainSets v0.5 #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Fixes for DomainSets v0.5 #59

merged 2 commits into from
Aug 3, 2021

Conversation

dlfivefifty
Copy link
Member

No description provided.

@Rapos0
Copy link

Rapos0 commented Aug 1, 2021

For ApproxFun ecosystem to work with DomainSet 0.5 ApproxFunFourier must also be updated, otherwise requirements compatibility will fail with other updated libs such as ModelingToolkit

@dlfivefifty
Copy link
Member Author

Sorry this got side-tracked due to some difficult fixes needed. I'll try to finish

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #59 (4ee694a) into master (2be3bbf) will decrease coverage by 0.02%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   57.41%   57.38%   -0.03%     
==========================================
  Files          27       27              
  Lines        2287     2288       +1     
==========================================
  Hits         1313     1313              
- Misses        974      975       +1     
Impacted Files Coverage Δ
src/Domains/Domains.jl 16.66% <25.00%> (-16.67%) ⬇️
src/Domains/Arc.jl 51.21% <100.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be3bbf...4ee694a. Read the comment docs.

@dlfivefifty dlfivefifty merged commit 1ed2407 into master Aug 3, 2021
@dlfivefifty dlfivefifty deleted the DomainSets-v0.5 branch August 3, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants