Skip to content

type-stability in Fun(identity, ::Jacobi) #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 4, 2022

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Aug 4, 2022

Address a common case of the domain being an interval, by recognizing that a constant corresponds to the n=0 coefficient. After this,

julia> @inferred Fun(identity, Legendre(-1..1))
Fun(Legendre(-1..1), [0.0, 1.0])

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #82 (54e5160) into master (7cba684) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   57.28%   57.41%   +0.12%     
==========================================
  Files          27       27              
  Lines        2395     2402       +7     
==========================================
+ Hits         1372     1379       +7     
  Misses       1023     1023              
Impacted Files Coverage Δ
src/Spaces/Jacobi/Jacobi.jl 56.43% <100.00%> (+3.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jishnub
Copy link
Member Author

jishnub commented Aug 4, 2022

This is possibly incorrect, so I'm closing this. bug fixed now.

@jishnub jishnub closed this Aug 4, 2022
@jishnub jishnub reopened this Aug 4, 2022
@jishnub jishnub merged commit 81e2851 into JuliaApproximation:master Aug 4, 2022
@jishnub jishnub deleted the funinferjac branch August 4, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant