Skip to content

Negative lower bandwidth for Jacobi derivative #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Sep 5, 2022

Following https://en.wikipedia.org/wiki/Jacobi_polynomials#Derivatives, d/dx(P^(a.b)_n(x))=(..) P^(a+1.b+1)_{n-1}(x), so only one band should be populated
On master

julia> Derivative(Legendre())
ConcreteDerivative : Legendre()  Jacobi(1.0,1.0)
 0.0  1.0                                  
     0.0  1.5                              
         0.0  2.0                          
             0.0  2.5                      
                 0.0  3.0                  
                     0.0  3.5              
                         0.0  4.0          
                             0.0  4.5      
                                 0.0  5.0  
                                     0.0  
                                         

After this PR

julia> Derivative(Legendre())
ConcreteDerivative : Legendre()  Jacobi(1.0,1.0)
   1.0                                  
       1.5                              
           2.0                          
               2.5                      
                   3.0                  
                       3.5              
                           4.0          
                               4.5      
                                   5.0  
                                       
                                       

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Base: 58.98% // Head: 58.98% // No change to project coverage 👍

Coverage data is based on head (a2f6fab) compared to base (4f2c6e4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   58.98%   58.98%           
=======================================
  Files          28       28           
  Lines        2460     2460           
=======================================
  Hits         1451     1451           
  Misses       1009     1009           
Impacted Files Coverage Δ
src/Spaces/Jacobi/JacobiOperators.jl 59.54% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit 91673b3 into JuliaApproximation:master Sep 6, 2022
@jishnub jishnub deleted the jacobiderivbw branch September 6, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant