Skip to content

Fix #136 #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2023
Merged

Fix #136 #145

merged 2 commits into from
Jul 30, 2023

Conversation

putianyi889
Copy link
Contributor

@putianyi889 putianyi889 commented Jul 14, 2023

After this PR:

julia> @time Jacobi(100,100) \ Jacobi(0,0);
  0.044945 seconds (2.79 k allocations: 263.168 KiB)

Note that getindex is still very slow due to LazyArrays.jl.

Weighted Jacobi conversion is not fixed.

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Patch coverage: 94.73% and project coverage change: +0.08% 🎉

Comparison is base (aaa182b) 91.76% compared to head (cac0897) 91.84%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   91.76%   91.84%   +0.08%     
==========================================
  Files          17       17              
  Lines        1822     1840      +18     
==========================================
+ Hits         1672     1690      +18     
  Misses        150      150              
Files Changed Coverage Δ
src/classical/jacobi.jl 90.27% <94.73%> (+0.64%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlfivefifty
Copy link
Member

Can you add tests to cover the two remaining cases?

@dlfivefifty dlfivefifty merged commit 40752c1 into JuliaApproximation:main Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants