-
Notifications
You must be signed in to change notification settings - Fork 8
Implement gausslobatto / gaussradau and Monic
#199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There is a routine But the cost of building the OPs is so fast compared to computing eigenvalues it wouldn't matter anyways. Though perhaps its worth making a |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
==========================================
+ Coverage 90.75% 91.06% +0.31%
==========================================
Files 17 18 +1
Lines 1936 1992 +56
==========================================
+ Hits 1757 1814 +57
+ Misses 179 178 -1 ☔ View full report in Codecov by Sentry. |
Would you prefer I rewrite it using |
I think making a type for |
Alright. I'll add |
Now added |
Monic
Anything left to do here? |
@@ -0,0 +1,38 @@ | |||
struct Monic{T,OPs<:AbstractQuasiMatrix{T},NL} <: OrthogonalPolynomial{T} | |||
P::Normalized{T,OPs,NL} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this actually benefit from requiring normalized OPs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes the code for getting the recurrence coefficients simpler I think
Implements
gaussradau
andgausslobatto
for computing quadrature weights using Gauss-Radau or Gauss-Lobatto quadrature, respectively.Is there a proper way I should be getting the monic polynomials? Or are my loops fine?