Skip to content

Introduce plan_transform #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Oct 13, 2022
Merged

Introduce plan_transform #134

merged 23 commits into from
Oct 13, 2022

Conversation

dlfivefifty
Copy link
Member

No description provided.

@dlfivefifty dlfivefifty changed the title WIP: Introduce plan_transform Introduce plan_transform Aug 14, 2022
@dlfivefifty
Copy link
Member Author

@jagot any thoughts? This is to clean up the notion of transform. That is, we factorization of a quasimatrix now reduces to plan_transform.

It should also support multi-dimensional transforms a la plan_fft.

@codecov
Copy link

codecov bot commented Aug 14, 2022

Codecov Report

Base: 91.47% // Head: 91.71% // Increases project coverage by +0.24% 🎉

Coverage data is based on head (56ba08b) compared to base (21561bc).
Patch coverage: 93.87% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   91.47%   91.71%   +0.24%     
==========================================
  Files           7        8       +1     
  Lines         610      640      +30     
==========================================
+ Hits          558      587      +29     
- Misses         52       53       +1     
Impacted Files Coverage Δ
src/bases/basisconcat.jl 98.03% <ø> (ø)
src/bases/basiskron.jl 0.00% <0.00%> (ø)
src/bases/splines.jl 96.51% <ø> (ø)
src/bases/bases.jl 92.21% <95.55%> (+0.68%) ⬆️
src/ContinuumArrays.jl 88.57% <100.00%> (+0.69%) ⬆️
src/operators.jl 76.78% <100.00%> (+0.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dlfivefifty
Copy link
Member Author

@MikaelSlevinsky

@jagot
Copy link
Member

jagot commented Aug 15, 2022

Without understanding everything in detail, I think it looks fine. I don't really use the internals, and It seems the interface stays the same? With expand and transform as added convenience wrappers.

@dlfivefifty
Copy link
Member Author

Yes that is correct.

I'm still not sure about the name Diff. In LazyArrays.jl I'm exporting something else called Diff which is a lazy version of diff(A; dims=d).... but that isn't actually used anywhere....

@dlfivefifty
Copy link
Member Author

I decided to leave it Derivative for now (need to remove Diff from LazyArrays.jl first)

@dlfivefifty dlfivefifty merged commit bbb032f into master Oct 13, 2022
@dlfivefifty dlfivefifty deleted the dl/plan_transform branch October 13, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants