-
Notifications
You must be signed in to change notification settings - Fork 6
Introduce plan_transform #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jagot any thoughts? This is to clean up the notion of transform. That is, we factorization of a quasimatrix now reduces to It should also support multi-dimensional transforms a la |
Codecov ReportBase: 91.47% // Head: 91.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #134 +/- ##
==========================================
+ Coverage 91.47% 91.71% +0.24%
==========================================
Files 7 8 +1
Lines 610 640 +30
==========================================
+ Hits 558 587 +29
- Misses 52 53 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Without understanding everything in detail, I think it looks fine. I don't really use the internals, and It seems the interface stays the same? With |
Yes that is correct. I'm still not sure about the name |
I decided to leave it |
No description provided.