Skip to content

Give index information to BoundsError in getindex for splines #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

DanielVandH
Copy link
Member

BoundsError() throws an uninformative error - just BoundsError without any axis or index information. This adds that information. This also adds a @boundscheck.

@dlfivefifty
Copy link
Member

You should be able to merge this youeself once tests pass?

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base (171465a) to head (d243564).
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #188       +/-   ##
===========================================
+ Coverage    0.00%   90.47%   +90.47%     
===========================================
  Files          11       11               
  Lines         768      819       +51     
===========================================
+ Hits            0      741      +741     
+ Misses        768       78      -690     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielVandH
Copy link
Member Author

Hm, no I don't have the ability to.

@dlfivefifty
Copy link
Member

I just added a maintain "role" . Can you do it now?

@DanielVandH DanielVandH merged commit e178b30 into JuliaApproximation:master Aug 14, 2024
12 checks passed
@DanielVandH
Copy link
Member Author

Thanks!

@DanielVandH DanielVandH deleted the boundserror branch August 14, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants