Skip to content

Add AffineMap #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 13, 2019
Merged

Add AffineMap #23

merged 17 commits into from
Nov 13, 2019

Conversation

dlfivefifty
Copy link
Member

This is a POC for #17

Surprisingly easy to get working actually.

@codecov
Copy link

codecov bot commented Oct 26, 2019

Codecov Report

Merging #23 into master will increase coverage by 4.46%.
The diff coverage is 60.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   56.11%   60.58%   +4.46%     
==========================================
  Files           4        4              
  Lines         180      241      +61     
==========================================
+ Hits          101      146      +45     
- Misses         79       95      +16
Impacted Files Coverage Δ
src/operators.jl 41.17% <ø> (+2.09%) ⬆️
src/bases/bases.jl 44.64% <50%> (+35.55%) ⬆️
src/bases/splines.jl 96.66% <50%> (-1.58%) ⬇️
src/ContinuumArrays.jl 70% <81.48%> (+30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b50508...a7a0f19. Read the comment docs.

@dlfivefifty
Copy link
Member Author

Note to self: next step is copying subarraylayout for ApplyLayout{typeof(*)} to work with SubQuasiArray and use it to materialize.

@dlfivefifty
Copy link
Member Author

@jagot this is close to merging. Another change is that now things like L[:,2:end-1] are left as SubQuasiArray, and the L*P equivalence happens in the multiplication.

@jagot
Copy link
Member

jagot commented Oct 28, 2019

This seems very cool, I hope to be able to have a look tomorrow. Is it easy/possible to have piecewise variable changes? How is the Jacobian provided? (Unless AD is introduced)

@dlfivefifty dlfivefifty merged commit e67d37f into master Nov 13, 2019
@dlfivefifty dlfivefifty deleted the dl/affinemaps branch November 13, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants