Add spin-weighted spherical harmonics #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
- Coverage 81.06% 75.36% -5.71%
==========================================
Files 12 12
Lines 1273 1368 +95
==========================================
- Hits 1032 1031 -1
- Misses 241 337 +96
Continue to review full report at Codecov.
|
don't export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for spin-weighted spherical harmonics based on the minor release https://github.com/MikaelSlevinsky/FastTransforms/releases/tag/v0.3.0. The spin-weighted spherical harmonics are L^2 orthonormal, use a complex Fourier series for the longitudinal basis, have positive real phase, and only support complex coefficients. There is an example (spinweighted.jl) to get folks started and comfortable with the convention. Spin-0 === spherical harmonics with complex Fourier basis (Laurent in ApproxFun).
There are other goodies in that minor release that are added, e.g. SIMD Horner's rule and Clenshaw's algorithm. The computational kernels have a new API to be a little bit more flexible to new more exotic multivariate orthogonal polynomials that are isomorphic to the canonical spherical/disk/triangular settings.
I accidentally broke the tetrahedral harmonics, but that can be fixed with a patch release to this series (v0.9).