Skip to content

Enum of transforms #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Aug 3, 2022

Instead of using a number of consts, we may use an enum. This doesn't change any behavior, but makes the types more readable.

julia> f = FastTransforms.plan_cheb2jac(rand(10), 0, 0);

julia> typeof(f)
FastTransforms.FTPlan{Float64, 1, FastTransforms.CHEB2JAC}

Should be non-breaking. I've checked locally that the tests for ApproxFun pass with this PR.

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #181 (d021a4e) into master (8a82d79) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
- Coverage   78.79%   78.75%   -0.04%     
==========================================
  Files          13       13              
  Lines        2108     2109       +1     
==========================================
  Hits         1661     1661              
- Misses        447      448       +1     
Impacted Files Coverage Δ
src/libfasttransforms.jl 77.81% <0.00%> (-0.14%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MikaelSlevinsky
Copy link
Member

For historical reference, this structure was taken from FFTW.jl, https://github.com/JuliaMath/FFTW.jl/blob/17bc81a0fcf9875d777ea4bee2fca70fc23c8a0c/src/fft.jl#L81-#L99.

@MikaelSlevinsky MikaelSlevinsky merged commit 67b345e into JuliaApproximation:master Aug 3, 2022
@jishnub jishnub deleted the enum branch August 4, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants