-
Notifications
You must be signed in to change notification settings - Fork 27
Restore Toeplitz-dot-Hankel #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #198 +/- ##
==========================================
+ Coverage 78.88% 81.45% +2.57%
==========================================
Files 13 15 +2
Lines 2169 2508 +339
==========================================
+ Hits 1711 2043 +332
- Misses 458 465 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Any idea why so many tests fail? This isn’t specific to this PR |
See JuliaLang/julia#48907 and JuliaLang/julia#48187 for the windows 1.8.4+ fails. There have been no new binaries, so I'm not convinced it's an issue with the library itself, but I'm not sure. |
Looks like the Windows testing issue (a bugfix in GCC 12.2 for a bug in libgomp 12.1) has been fixed! JuliaLang/julia#48907 |
For large vectors we need Toeplitz-dot-Hankel as current
leg2cheb
andcheb2leg
s plan has bad complexity.It was also straightforward to generalise to 2D leveraging the FFTW. With 4 threads applying the plan is now 3x slower than
leg2cheb
:I suspect with more cores we can reach similar speeds.