Add nonuniform fast Fourier transforms #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/FastTransforms.jl # test/runtests.jl
reverse type I and II to match the paper add `lambertw` as a temporary measure add docstrings and section in readme
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 84.61% 85.65% +1.04%
==========================================
Files 25 27 +2
Lines 2210 2454 +244
==========================================
+ Hits 1870 2102 +232
- Misses 340 352 +12
Continue to review full report at Codecov.
|
framework should allow other types a-b to be implemented too.
|
Looks great! Thanks. You did all the types for the 2D NUFFT too! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ajt60gaibb, I've updated this branch to include
nufft3and the type-I and II inverses. The plans now create types and use optimized Julia code... the timings appear as good as the Matlab timings in your pre-print.