Set FFTW lower compat bound to v1.7 #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #221 +/- ##
==========================================
+ Coverage 81.76% 82.02% +0.26%
==========================================
Files 15 15
Lines 2539 2537 -2
==========================================
+ Hits 2076 2081 +5
+ Misses 463 456 -7
☔ View full report in Codecov by Sentry. |
Open
|
@dlfivefifty this should be good to merge |
|
Bump, would be good to have this merged |
|
Bump |
|
Are we sure this isn't a breaking change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes breakages introduced by FFTW v1.7, and makes tests pass locally for me on Linux. It also simplifies types, and gets rid of hack-y workarounds for compatibility with FFTW v1.6.