Add Zernike(0,a) Jacobi matrices #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
==========================================
+ Coverage 95.88% 95.97% +0.08%
==========================================
Files 4 4
Lines 656 720 +64
==========================================
+ Hits 629 691 +62
- Misses 27 29 +2
Continue to review full report at Codecov.
|
|
@dlfivefifty The only thing missed in coverage now are the non-implemented case of non-zero first basis parameter where I just throw a not implemented yet error. Not sure if anything can be done about that loss of coverage? |
TSGut
changed the title
|
I think this is ready to merge. |
|
Cool. Is the formula simpler in terms of But this is fine for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sorting scheme we chose for Zernike is a bit of a hassle for the Jacobi matrices and so is the normalization but I got it all working now.
I will see how much more performance I can squeeze out by removing redundant filtering / sorting applications but for most standard applications it should be fine, i.e. it's about as fast as the Y matrix for the JacobiTriangle().