-
Notifications
You must be signed in to change notification settings - Fork 5
Simplify Zernike Jacobi matrices + bugfixes #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
- Coverage 96.23% 96.15% -0.09%
==========================================
Files 4 4
Lines 718 702 -16
==========================================
- Hits 691 675 -16
Misses 27 27
Continue to review full report at Codecov.
|
I think this covers all the actions one may want to do with these operators for now. Ready to merge. |
@dlfivefifty So what's the mechanism allowing for the use of |
That should just work provided you overload |
I figured out why it wasn't working. Basically, the stuff you linked at one point requires I think I fixed it by overloading copy for the bands type. |
@dlfivefifty This is ready to merge I think. |
By comparing with the Triangle code, I've decided it's better to not have the custom type for the Jacobi matrices for now, especially since it just leads to harder to read and debug code and actually slows things down for an enduser. I've also removed the BlockHcat call. As a result, the tests I implemented here won't pass until the addition bug mentioned here #123 (comment) has been resolved. |
@dlfivefifty This is ready to merge and can now do polynomial multiplication operators. I'm pretty sure the coverage reduction is an artifact due to a reduction in lines of code as the patch diff is 100%. |
This makes the fixes made in JuliaLinearAlgebra/InfiniteLinearAlgebra.jl#103 also work for the Zernike Jacobi matrices.