Add derivatives for WeightedTriangle #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those errors seem unrelated to this change. I don't actually see that error at all when running the tests locally either... |
|
Right, this is something I changed fixing plotting. I’ll have to fix it |
|
I think the failures are due to a bug in FastTransforms. |
|
@MikaelSlevinsky do you know why its crashing on Mac OS? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #179 +/- ##
==========================================
- Coverage 95.82% 95.67% -0.15%
==========================================
Files 6 6
Lines 958 972 +14
==========================================
+ Hits 918 930 +12
- Misses 40 42 +2 ☔ View full report in Codecov by Sentry. |
|
Nope, but there will be changes coming in FastTransforms that will require new binaries, so I'm almost certain it's because they haven't been generated in a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for derivatives of
WeightedTriangle. Currently it only works fora, b, c > 0since that is where the recurrence holds. Would it better to@assertthis in the functions for the time being, or just leave it?