Skip to content

Recompile invalidations from Static.jl #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

ChrisRackauckas
Copy link
Member

Since we know that Static.jl gives a lot of invalidations, and this is the spot where the yare introduced into downstream usage, this can be done to force recompilation and get much better precompile caches. While this will increase precompilation time, this should just be spread out among other packages and not necessarily be as noticable (in fact maybe reducing the amount done in OrdinaryDiffEq?)

Since we know that Static.jl gives a lot of invalidations, and this is the spot where the yare introduced into downstream usage, this can be done to force recompilation and get much better precompile caches. While this will increase precompilation time, this should just be spread out among other packages and not necessarily be as noticable (in fact maybe reducing the amount done in OrdinaryDiffEq?)
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #32 (1c368e0) into master (b182daf) will decrease coverage by 88.71%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #32       +/-   ##
==========================================
- Coverage   88.70%   0.00%   -88.71%     
==========================================
  Files          11      11               
  Lines        1319    1310        -9     
==========================================
- Hits         1170       0     -1170     
- Misses        149    1310     +1161     
Files Changed Coverage Δ
src/StaticArrayInterface.jl 0.00% <ø> (-84.62%) ⬇️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas
Copy link
Member Author

@chriselrod
Copy link
Contributor

@chriselrod do you know about this piracy? https://github.com/JuliaArrays/StaticArrayInterface.jl/actions/runs/6221161500/job/16882596945?pr=32#step:6:336

Yes. They're all JuliaSIMD packages.
At one point, I wanted to try and split things up so that more can precompile in parallel. I never really got that far/it doesn't help if there's a dependency chain, but it doesn't seem great to smash everything into one repo either. But that'd be the answer to piracy concerns.

@ChrisRackauckas ChrisRackauckas merged commit 3d33487 into master Sep 18, 2023
@ChrisRackauckas ChrisRackauckas deleted the recompile_invalidations branch September 18, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants