Skip to content

WIP: add more components #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

WIP: add more components #1

wants to merge 14 commits into from

Conversation

baggepinnen
Copy link
Contributor

@baggepinnen baggepinnen commented Feb 20, 2023

Current problems to be resolved:

  • Unclear how to attach components from Translational to components from Multibody since MTK errors when connectors of different types are used in connect.
    The example in runtest.jl tries to implement
    image
    where Spring is a 2D component with Flange connectors whereas Body is a multibody component with Frame connectors.
  • Currently, the World component is a hard-coded constant. This component is required for all models, and a new model-compiler pass that propagates the world component to all other components is required to run before the standard MTK passes. Some equations in multibody components refer to the world component, we need to figure out a way to defer the definition of these equations until the world component is known.

@YingboMa
Copy link
Contributor

Unclear how to attach components from Translational to components from Multibody since MTK errors when connectors of different types are used in connect.

The spring and body in the example are a part of Multibody as well.

https://build.openmodelica.org/Documentation/Modelica.Mechanics.MultiBody.Forces.Spring.html
https://build.openmodelica.org/Documentation/Modelica.Mechanics.MultiBody.Parts.Body.html

Currently, the World component is a hard-coded constant. This component is required for all models, and a new model-compiler pass that propagates the world component to all other components is required to run before the standard MTK passes. Some equations in multibody components refer to the world component, we need to figure out a way to defer the definition of these equations until the world component is known.

You can define a singleton with some overloads.

ModelingToolkit = "961ee093-0014-501f-94e3-6117800e7a78"
ModelingToolkitStandardLibrary = "16a59e39-deab-5bd0-87e4-056b12336739"
Rotations = "6038ab10-8711-5258-84ad-4b1120ba62dc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember compat

@baggepinnen
Copy link
Contributor Author

superseded by

@baggepinnen baggepinnen deleted the fb/components branch October 25, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants