Skip to content

Remove DOCUMENTER_KEY for regular documentation deployment #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

bauglir
Copy link
Contributor

@bauglir bauglir commented Apr 14, 2023

This secret is not actually necessary for deployment to work in this case. The GITHUB_TOKEN can also be used to push to the branch. Now that DOCUMENTER_KEY actually has a value and is set to an non-base64 encoded SSH key the deployment errors1.

Partially reverts 048a234.

Footnotes

  1. https://github.com/JuliaComputing/Multibody.jl/actions/runs/4697514324/jobs/8328667586

This secret is not actually necessary for deployment to work in this
case. The `GITHUB_TOKEN` can also be used to push to the branch. Now
that `DOCUMENTER_KEY` actually has a value and is set to an non-base64
encoded SSH key the deployment errors[^1].

Partially reverts 048a234.

[^1]: https://github.com/JuliaComputing/Multibody.jl/actions/runs/4697514324/jobs/8328667586
@bauglir bauglir self-assigned this Apr 14, 2023
@bauglir bauglir force-pushed the jk/more-documenter-ci-fixes branch from 99e304a to 46455ed Compare April 14, 2023 07:54
@bauglir bauglir merged commit c2aa965 into main Apr 14, 2023
@bauglir bauglir deleted the jk/more-documenter-ci-fixes branch April 14, 2023 07:58
bauglir added a commit that referenced this pull request Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant