Skip to content

Tweak add_tiny #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2020
Merged

Tweak add_tiny #104

merged 3 commits into from
Jul 23, 2020

Conversation

willtebbutt
Copy link
Member

This came up in JuliaGaussianProcesses/KernelFunctions.jl#138

There's some functionality that we've got that returns a Bool. add_tiny doesn't like this, so this is a fix for that.

@willtebbutt willtebbutt changed the title WIP: Tweak add_tiny Tweak add_tiny Jul 23, 2020
Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve subject to sorting out what is to be done with BigInt
I think leaving it as a BigFloat is correct.
float(x) gives the standard floating point number that is used for integer in various places.
Like SpecialFunctions.jl

Co-authored-by: Lyndon White <[email protected]>
@willtebbutt
Copy link
Member Author

Good catch. I've committed your suggestion -- I'll merge when tests pass.

@willtebbutt willtebbutt merged commit 0ee70d5 into master Jul 23, 2020
@willtebbutt willtebbutt deleted the wct/fix-tiny branch July 23, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants