simple fix for #140 #142
Merged
simple fix for #140 #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add that test here as well? |
|
OK, I'll add that test here. |
|
Once the test is added, this can be merged. |
|
I had to make an additional adjustment to make the tests pass on Julia 1.0. Additionally, if I use a random vector here: https://github.com/JuliaDiff/ReverseDiff.jl/pull/142/files#diff-516f2fc7e3b4733687c4f2f36918bd39R178 then one of further tests fails. |
|
Thanks @mateuszbaran! Sorry for the delayed merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to fix #140. The relevant test is here: JuliaDiff/DiffTests.jl#10 and locally it passes.