Fix for new BlockBandedMatrices #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
Dec 26, 2019
|
https://github.com/JuliaDiffEq/ArrayInterface.jl/blob/master/src/ArrayInterface.jl#L430-L431 |
|
Yes: it was a complete redesign to incorporate the block structure in the axes |
|
It looks like the use of blocklengths is an issue? |
|
JuliaDiff/FiniteDiff.jl#84 and JuliaArrays/ArrayInterface.jl#34 are the latest movements |
|
It looks like the latest test found an issue: getindex from Cartesians is trying to call Got exception outside of a @test
LoadError: MethodError: no method matching similar(::BlockBandedMatrices.BlockSkylineMatrix{Float64,Array{Float64,1},BlockBandedMatrices.BlockSkylineSizes{Tuple{BlockArrays.BlockedUnitRange{Array{Int64,1}},BlockArrays.BlockedUnitRange{Array{Int64,1}}},FillArrays.Fill{Int64,1,Tuple{Base.OneTo{Int64}}},FillArrays.Fill{Int64,1,Tuple{Base.OneTo{Int64}}},BandedMatrices.BandedMatrix{Int64,Array{Int64,2},Base.OneTo{Int64}},Array{Int64,1}}},
::Type{Float64}, ::Tuple{Base.IdentityUnitRange{BlockArrays.BlockedUnitRange{Array{Int64,1}}},Base.OneTo{Int64}})
Closest candidates are:
similar(!Matched::BlockArrays.BlockArray, ::Type{T}, ::Tuple{Union{Colon, Integer, Base.IdentityUnitRange, Base.OneTo, UnitRange},Vararg{Union{Colon, Integer, Base.IdentityUnitRange, Base.OneTo, UnitRange},N} where N}) where T at C:\Users\accou\.julia\packages\BlockArrays\FxyhD\src\blockarray.jl:353
similar(::BlockBandedMatrices.BlockSkylineMatrix, ::Type) at C:\Users\accou\.julia\packages\BlockBandedMatrices\ROxFN\src\BlockSkylineMatrix.jl:252
similar(::BlockBandedMatrices.BlockSkylineMatrix, ::Type, !Matched::BlockBandedMatrices.BlockSkylineSizes) at C:\Users\accou\.julia\packages\BlockBandedMatrices\ROxFN\src\BlockSkylineMatrix.jl:252
...
Stacktrace:
[1] similar(::BlockBandedMatrices.BlockSkylineMatrix{Float64,Array{Float64,1},BlockBandedMatrices.BlockSkylineSizes{Tuple{BlockArrays.BlockedUnitRange{Array{Int64,1}},BlockArrays.BlockedUnitRange{Array{Int64,1}}},FillArrays.Fill{Int64,1,Tuple{Base.OneTo{Int64}}},FillArrays.Fill{Int64,1,Tuple{Base.OneTo{Int64}}},BandedMatrices.BandedMatrix{Int64,Array{Int64,2},Base.OneTo{Int64}},Array{Int64,1}}}, ::Tuple{Base.IdentityUnitRange{BlockArrays.BlockedUnitRange{Array{Int64,1}}},Base.OneTo{Int64}}) at C:\Users\accou\.julia\packages\BlockArrays\FxyhD\src\abstractblockarray.jl:38
[2] _unsafe_getindex(::IndexCartesian, ::BlockBandedMatrices.BlockSkylineMatrix{Float64,Array{Float64,1},BlockBandedMatrices.BlockSkylineSizes{Tuple{BlockArrays.BlockedUnitRange{Array{Int64,1}},BlockArrays.BlockedUnitRange{Array{Int64,1}}},FillArrays.Fill{Int64,1,Tuple{Base.OneTo{Int64}}},FillArrays.Fill{Int64,1,Tuple{Base.OneTo{Int64}}},BandedMatrices.BandedMatrix{Int64,Array{Int64,2},Base.OneTo{Int64}},Array{Int64,1}}}, ::Base.Slice{BlockArrays.BlockedUnitRange{Array{Int64,1}}}, ::Array{Int64,1}) at .\multidimensional.jl:682
[3] _getindex(::IndexCartesian, ::BlockBandedMatrices.BlockSkylineMatrix{Float64,Array{Float64,1},BlockBandedMatrices.BlockSkylineSizes{Tuple{BlockArrays.BlockedUnitRange{Array{Int64,1}},BlockArrays.BlockedUnitRange{Array{Int64,1}}},FillArrays.Fill{Int64,1,Tuple{Base.OneTo{Int64}}},FillArrays.Fill{Int64,1,Tuple{Base.OneTo{Int64}}},BandedMatrices.BandedMatrix{Int64,Array{Int64,2},Base.OneTo{Int64}},Array{Int64,1}}}, ::Base.Slice{BlockArrays.BlockedUnitRange{Array{Int64,1}}}, ::Array{Int64,1}) at .\multidimensional.jl:670
[4] getindex at .\abstractarray.jl:981 [inlined]
[5] _testvalidity(::BlockBandedMatrices.BlockSkylineMatrix{Float64,Array{Float64,1},BlockBandedMatrices.BlockSkylineSizes{Tuple{BlockArrays.BlockedUnitRange{Array{Int64,1}},BlockArrays.BlockedUnitRange{Array{Int64,1}}},FillArrays.Fill{Int64,1,Tuple{Base.OneTo{Int64}}},FillArrays.Fill{Int64,1,Tuple{Base.OneTo{Int64}}},BandedMatrices.BandedMatrix{Int64,Array{Int64,2},Base.OneTo{Int64}},Array{Int64,1}}}) at C:\Users\accou\.julia\dev\SparseDiffTools\test\test_specialmatrices.jl:45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.