Fixed acyclic coloring #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matbesancon
reviewed
Dec 27, 2019
matbesancon
reviewed
Dec 27, 2019
matbesancon
reviewed
Dec 27, 2019
matbesancon
reviewed
Dec 27, 2019
matbesancon
reviewed
Dec 27, 2019
matbesancon
reviewed
Dec 27, 2019
matbesancon
reviewed
Dec 27, 2019
matbesancon
reviewed
Dec 27, 2019
matbesancon
reviewed
Dec 27, 2019
|
Still some errors, do you know where to look at? |
|
@matbesancon are you talking about errors in this PR or the travis build? It seems the build is failing because of some issues with methods related to BlockBandedMatrices. Acyclic tests are passing. |
|
Dang thanks, yes I was talking about the Travis build
…On Fri, Dec 27, 2019, 20:31 Pankaj Mishra ***@***.***> wrote:
@matbesancon <https://github.com/matbesancon> are you talking about
errors in this PR or the travis build? It seems the build is failing
because of some issues with methods related to BlockBandedMatrices. Acyclic
tests are passing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#85>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2FDMVJ764IFWDGV2EGPGLQ2ZJY7ANCNFSM4J7SX5RQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented modified version of acyclic coloring algorithm using disjoint sets with root as integer (representing the edge's position in the graph) instead of the edge object itself to avoid unforeseen errors. Also enforced initialization of the tuple vectors with
(0,0)instead ofundefto avoid random errors.Few performance enhancements that are possible in this implementation:
SimpleGraphs(nv, ne)function instead of generating graphs usingrand(1:nv)Fixes #75