Skip to content

Commit 966d83a

Browse files
committed
Corrected set_params! and get_params
1 parent d6a95fc commit 966d83a

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

src/generic.jl

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,9 @@ function set!(k::Kernel,x)
3434
@error "Setting parameters to this kernel is either not possible or has not been implemented"
3535
end
3636

37-
function set!(k::Kernel{T,ScaleTransform{Base.RefValue{<:Tρ}}}::Tρ) where {T,Tρ<:Real}
38-
set!(k.transform,ρ)
39-
end
40-
41-
function set!(k::Kernel{T,ScaleTransform{<:AbstractVector{<:Tρ}}}::AbstractVector{<:Tρ}) where {T,Tρ<:Real}
42-
set!(k.transform,ρ)
43-
end
37+
set_params!(k::Kernel{T,ScaleTransform{<:Base.RefValue{<:Tρ}}}::AbstractVector{Tρ}) where {T,Tρ<:Real} = set!(k.transform,ρ[1])
38+
set_params!(k::Kernel{T,ScaleTransform{<:AbstractVector{<:Tρ}}}::AbstractVector{<:Tρ}) where {T,Tρ<:Real} = set!(k.transform,ρ)
39+
set_params!(k::Kernel{T,LowRankTransform{<:AbstractMatrix{<:Tm}}},m::AbstractMatrix{<:Tm}) where {T,Tm<:Real} = set!(k.transform,m)
4440

45-
function set!(k::Kernel{T,LowRankTransform{<:AbstractMatrix{<:Tm}}},m::AbstractMatrix{<:Tm}) where {T,Tm<:Real}
46-
set!(k.transform,m)
47-
end
41+
get_params(k::Kernel{T,<:ScaleTransform{<:Base.RefValue{<:Tρ}}}) where {T,Tρ} = [t.transform.s[]]
42+
get_params(k::Kernel{T,<:ScaleTransform{<:AbstractVector{<:Tρ}}}) where {T,Tρ} = t.transform.s

0 commit comments

Comments
 (0)