Skip to content

Use pairwise! for inplace operations #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2020
Merged

Use pairwise! for inplace operations #102

merged 2 commits into from
Apr 28, 2020

Conversation

devmotion
Copy link
Member

Fixes #90 and a bug in the implementation of kernelmatrix! for FBMKernel.

theogf
theogf reviewed Apr 27, 2020
View reviewed changes
Copy link
Member

@theogf theogf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some tests on the added pairwise! would be nice

@devmotion
Copy link
Member Author

Maybe some tests on the added pairwise! would be nice

I assumed it would be sufficient that every test of kernelmatrix! for a SimpleKernel tests pairwise implicitly. Tests of the pairwise! type piracy definition should be part of Distances (if it is added there).

willtebbutt
willtebbutt requested changes Apr 28, 2020
View reviewed changes
Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just needs a few more tests :)

@willtebbutt
Copy link
Member

I assumed it would be sufficient that every test of kernelmatrix! for a SimpleKernel tests pairwise implicitly. Tests of the pairwise! type piracy definition should be part of Distances (if it is added there).

I agree that the right place for this is there, but it's still a good idea to have direct tests for this implementation. Makes it unambiguously clear what's causing problems if something breaks at some point, rather than having to deduce that it must be the pairwise! implementation because everything is breaking.

willtebbutt
willtebbutt approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding these!

@devmotion devmotion merged commit b10684d into JuliaGaussianProcesses:master Apr 28, 2020
@devmotion devmotion deleted the pairwise! branch April 28, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theogf theogf theogf left review comments

@willtebbutt willtebbutt willtebbutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pairwise! for kernelmatrix!
3 participants
@devmotion @willtebbutt @theogf