Optimization of ScaleTransform for SimpleKernel #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theogf
reviewed
Apr 27, 2020
theogf
approved these changes
Apr 27, 2020
|
Thanks for taking a look at this. Before merging, could someone please explain to me why these methods are more efficient than what would otherwise happen? I'm struggling to figure it out. |
|
Well if you would multiply |
|
Ah, okay. @devmotion could you add a comment to this effect? |
|
I added a comment and constrained the optimization to |
Co-Authored-By: willtebbutt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96 by adapting the old code to the new interface. I'm not sure, maybe there's a better way to achieve this optimization?