Use LinearTransform instead of LowRankTransform #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtebbutt
approved these changes
Apr 27, 2020
Co-Authored-By: Théo Galy-Fajou <[email protected]> Co-Authored-By: willtebbutt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97.
In principle, the ARDTransform could be a special case of a LinearTransform with a diagonal matrix, but I guess we want to keep them separate? IMO we should keep at least the ScaleTransform since it could be applied in infinite-dimensional vector spaces as well whereas that's not the case for the LinearTransform and ARDTransform.