Relaxed transform to be used on Kernel #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtebbutt
approved these changes
Jun 22, 2020
Co-authored-by: willtebbutt <[email protected]>
devmotion
reviewed
Jun 22, 2020
|
Could we add a test for this bug? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already part of #38 but since it is likely to be closed and that this bug is pretty bad I put it separately here.
This fix the problem of
transform(transform(SEKernel(), 2.0), 2.0).Would not work because
transformonly acceptBaseKernel.Now when
transformis applied on aTransformedKernel, the transform becomes aChainTransform.