Skip to content

Enforce 'Tuple{Any, Int}' type inputs for IndependentMOKernel #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2020
Merged

Enforce 'Tuple{Any, Int}' type inputs for IndependentMOKernel #145

merged 1 commit into from
Aug 2, 2020

Conversation

sharanry
Copy link
Contributor

@sharanry sharanry commented Aug 2, 2020 •
edited
Loading

willtebbutt
willtebbutt approved these changes Aug 2, 2020
View reviewed changes
Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Unfortunately we don't currently have any e.g. string- or graph-kernels to test this again to prevent regression, so I think this is probably good to go.

@sharanry sharanry merged commit 914ce5a into master Aug 2, 2020
@willtebbutt
Copy link
Member

Eurgh, I forgot to ask for a version bump. @sharanry could you bump and release please so that we capture this fix in a patch release?

@sharanry sharanry deleted the sharanry-patch-2 branch September 15, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willtebbutt willtebbutt willtebbutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharanry @willtebbutt