Input check relaxation and change of `pairwise #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess it would be good to add some tests? |
willtebbutt
reviewed
Aug 3, 2020
src/utils.jl
Outdated
| @@ -94,9 +91,24 @@ For a transform return its parameters, for a `ChainTransform` return a vector of | |||
| """ | |||
| #params | |||
|
|
|||
| dim(x) = 0 | |||
There was a problem hiding this comment.
Could you add another comment here pointing out that this is a passes-by-default choice.
|
@willtebbutt I added some docs and changed slightly the |
devmotion
reviewed
Aug 4, 2020
theogf
commented
Aug 4, 2020
Co-authored-by: David Widmann <[email protected]>
willtebbutt
reviewed
Aug 4, 2020
docs/src/create_kernel.md
Outdated
| - Define the trainable parameters of your kernel with `KernelFunctions.trainable(k)` which should return a `Tuple` of your parameters. | ||
| This parameters will be then passed to `Flux.params` function | ||
| - `KernelFunctions.iskroncompatible(k)`, if your kernel factorizes in the dimensions. You can declare your kernel as `iskroncompatible(k) = true` | ||
| - `KernelFunctions.dim`: by default the dimension of the inputs will only be checked for vectors of `AbstractVector{<:Real}`. |
There was a problem hiding this comment.
It might be good to generalise this to say that you're allowed to add methods to validate_inputs if you've got special checks that you want to run for your input types, with dim being a nice special case.
willtebbutt
reviewed
Aug 4, 2020
Co-authored-by: willtebbutt <[email protected]>
willtebbutt
approved these changes
Aug 4, 2020
There was a problem hiding this comment.
I'm happy with this now, subject to @devmotion being happy and a patch version bump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at :
validate_dimsis replaced byvalidate_inputs. It will only check dimensions forColVecsandRowVecs.broadcast(k, x, y')bybroadcast(k, x, permutedims(y))in ourpairwisefor vectors. It appears to solve some Zygote issue (for me) and make it more coherent with the rest of the package