-
Notifications
You must be signed in to change notification settings - Fork 36
SelectTransform extended to Symbols #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the PR @molet . Just a couple of requests:
- Could you try running
test_ADs
on aSelectTransform
withSymbol
s, just to ensure that it actually does work as intended. - Bump the patch version so we can make a release :)
@test kernelmatrix(tx_row, X, Y, obsdim=2) == kernelmatrix(ta_row, A, B, obsdim=2) | ||
@test kernelmatrix(tx_col, X, Z, obsdim=1) == kernelmatrix(ta_col, A, C, obsdim=1) | ||
|
||
@testset "$(AD)" for AD in [:Zygote, :ForwardDiff] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@molet Did the test_AD
function not work for this code?
Unfortunately |
Oh I see. Yes, that is unfortunate -- our AD testing is in need of a re-vamp generally. Good to know that's a thing we've accidentally been assuming. |
Don't worry too much about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge when tests pass.
Damn. These tests failed because they take too long. @devmotion @theogf any thoughts on the best way to work around this? Do we just add more |
Hmm yes we could try that. I guess AxisArrays in general might not be optimized for the use with Zygote - in my experience the package is quite rough and a bit suboptimal and slightly outdated. Maybe we could use some other custom arrays in the tests such as OffsetArrays or AxisKeys. |
Hmm I'm reluctant to change the array type being tested for the sake of making our tests run faster. @molet could you print a space (I was thinking just |
SelectTransform
functionality is extended toSymbol
s making it applicable toAxisArrays
.