Skip to content

SelectTransform extended to Symbols #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 21, 2020
Merged

SelectTransform extended to Symbols #155

merged 11 commits into from
Aug 21, 2020

Conversation

molet
Copy link
Contributor

@molet molet commented Aug 20, 2020

SelectTransform functionality is extended to Symbols making it applicable to AxisArrays.

Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR @molet . Just a couple of requests:

  1. Could you try running test_ADs on a SelectTransform with Symbols, just to ensure that it actually does work as intended.
  2. Bump the patch version so we can make a release :)

@test kernelmatrix(tx_row, X, Y, obsdim=2) == kernelmatrix(ta_row, A, B, obsdim=2)
@test kernelmatrix(tx_col, X, Z, obsdim=1) == kernelmatrix(ta_col, A, C, obsdim=1)

@testset "$(AD)" for AD in [:Zygote, :ForwardDiff]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@molet Did the test_AD function not work for this code?

@molet
Copy link
Contributor Author

molet commented Aug 20, 2020

  1. Could you try running test_ADs on a SelectTransform with Symbols, just to ensure that it actually does work as intended.

Unfortunately test_ADs function creates the input matrices inside so I cannot use that directly to test SelectTransform with Symbols. Anyway, I added a bunch of tests for Zygote and ForwardDiff. ReverseDiff unfortunately breaks - I'm still investigating why.

@willtebbutt
Copy link
Member

willtebbutt commented Aug 20, 2020

Oh I see. Yes, that is unfortunate -- our AD testing is in need of a re-vamp generally. Good to know that's a thing we've accidentally been assuming.

@willtebbutt
Copy link
Member

willtebbutt commented Aug 20, 2020

Don't worry too much about ReverseDiff for now if it's being a pain -- I would just add a single test using @test_broken so we don't forget about it. Then I'm happy to approve.

Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge when tests pass.

@willtebbutt
Copy link
Member

Damn. These tests failed because they take too long. @devmotion @theogf any thoughts on the best way to work around this? Do we just add more @info statements or something?

@devmotion
Copy link
Member

Hmm yes we could try that. I guess AxisArrays in general might not be optimized for the use with Zygote - in my experience the package is quite rough and a bit suboptimal and slightly outdated. Maybe we could use some other custom arrays in the tests such as OffsetArrays or AxisKeys.

@willtebbutt
Copy link
Member

Hmm I'm reluctant to change the array type being tested for the sake of making our tests run faster.

@molet could you print a space (I was thinking just print(" ")) after each of the files in the "transform" test set has run? This should deal with this issue.

@willtebbutt willtebbutt merged commit a92fcc2 into JuliaGaussianProcesses:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants